Update client to the latest version of Threat Stack V2 Api. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: - Adding HAWK authentication - Update methods to always require a param that the api requires - Add new endpoints - Remove methods for the endpoints that were removed
tushar-eligible
approved these changes
Aug 9, 2018
|
Hi, What is the difference between API_TOKEN and api_key? |
Author
|
Hey @tushar-eligible good catch. Looks like I missed something in the docs. |
|
Thanks, I want to use this library and getting stuck here. |
|
user id is not needed ? |
… and use arguments instead
Author
|
@tushar-eligible You do need to pass in a user id. I've made another change to the readme to reflect this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Today we released significant updates to the Beta of our V2 API.
This PR updates this library to work with these changes.
Changes include:
Please let me know if there are any changes you would like to the PR.
You can check out the updated docs: https://apidocs.threatstack.com/